This repository was archived by the owner on Sep 9, 2020. It is now read-only.
gps: source cache: fix flaky bolt test #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdboyer
approved these changes
Sep 6, 2017
Member
sdboyer
left a comment
sdboyer
left a comment
There was a problem hiding this comment.
seems like that should be fine for a test. best to give ourselves plenty of breathing room, on such a thing.
Member
|
not gonna worry about waiting for the OSX test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This PR aims to improve the flaky
TestBoltCacheTimeout, which randomly fails on CI and for some people locally (I haven't actually reproduced it). For the purpose of the failing test, we can just force a future timestamp.